From 37ca4cb7d61c0460d5d8e3dce35964ffc72a9f9d Mon Sep 17 00:00:00 2001 From: silverwind Date: Wed, 19 Oct 2022 08:50:19 +0200 Subject: [PATCH] Remove vitest globals (#21505) Explicitly import them instead which is cleaner and enables better editor integration. Co-authored-by: Lunny Xiao Co-authored-by: wxiaoguang --- .eslintrc.yaml | 3 --- vitest.config.js | 1 - web_src/js/features/repo-findfile.test.js | 1 + web_src/js/svg.test.js | 1 + web_src/js/utils.test.js | 1 + 5 files changed, 3 insertions(+), 4 deletions(-) diff --git a/.eslintrc.yaml b/.eslintrc.yaml index 66d4452ec5..4dafc8f492 100644 --- a/.eslintrc.yaml +++ b/.eslintrc.yaml @@ -35,9 +35,6 @@ overrides: rules: import/no-unresolved: [0] import/no-extraneous-dependencies: [0] - - files: ["*.test.js"] - env: - jest: true - files: ["*.config.js"] rules: import/no-unused-modules: [0] diff --git a/vitest.config.js b/vitest.config.js index d17abd26c3..838360970f 100644 --- a/vitest.config.js +++ b/vitest.config.js @@ -24,7 +24,6 @@ export default defineConfig({ open: false, allowOnly: true, passWithNoTests: true, - globals: true, watch: false, }, plugins: [ diff --git a/web_src/js/features/repo-findfile.test.js b/web_src/js/features/repo-findfile.test.js index 2d96ed4463..a90b0bf0a2 100644 --- a/web_src/js/features/repo-findfile.test.js +++ b/web_src/js/features/repo-findfile.test.js @@ -1,3 +1,4 @@ +import {describe, expect, test} from 'vitest'; import {strSubMatch, calcMatchedWeight, filterRepoFilesWeighted} from './repo-findfile.js'; describe('Repo Find Files', () => { diff --git a/web_src/js/svg.test.js b/web_src/js/svg.test.js index 9f2836b667..c5d6d07535 100644 --- a/web_src/js/svg.test.js +++ b/web_src/js/svg.test.js @@ -1,3 +1,4 @@ +import {expect, test} from 'vitest'; import {svg} from './svg.js'; test('svg', () => { diff --git a/web_src/js/utils.test.js b/web_src/js/utils.test.js index b56d80ac7a..7bf5bb7eb6 100644 --- a/web_src/js/utils.test.js +++ b/web_src/js/utils.test.js @@ -1,3 +1,4 @@ +import {expect, test} from 'vitest'; import { basename, extname, isObject, uniq, stripTags, joinPaths, parseIssueHref, prettyNumber, parseUrl,