From 79da4bbc566cd3b1c028ca0b747c196fc02990f7 Mon Sep 17 00:00:00 2001 From: wxiaoguang Date: Sun, 7 Jan 2024 23:18:04 +0800 Subject: [PATCH] Suggest to use Type=simple for systemd service (#28717) Although the systemd notify support was added, it seems that there are some problems (#28553, for the "non-installed" instance) --- contrib/systemd/gitea.service | 3 +-- modules/graceful/manager_common.go | 3 +++ 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/contrib/systemd/gitea.service b/contrib/systemd/gitea.service index c097fb0d17..d205c6ee8b 100644 --- a/contrib/systemd/gitea.service +++ b/contrib/systemd/gitea.service @@ -52,7 +52,7 @@ After=network.target # Uncomment the next line if you have repos with lots of files and get a HTTP 500 error because of that # LimitNOFILE=524288:524288 RestartSec=2s -Type=notify +Type=simple User=git Group=git WorkingDirectory=/var/lib/gitea/ @@ -62,7 +62,6 @@ WorkingDirectory=/var/lib/gitea/ ExecStart=/usr/local/bin/gitea web --config /etc/gitea/app.ini Restart=always Environment=USER=git HOME=/home/git GITEA_WORK_DIR=/var/lib/gitea -WatchdogSec=30s # If you install Git to directory prefix other than default PATH (which happens # for example if you install other versions of Git side-to-side with # distribution version), uncomment below line and add that prefix to PATH diff --git a/modules/graceful/manager_common.go b/modules/graceful/manager_common.go index aaf008670c..27196e1531 100644 --- a/modules/graceful/manager_common.go +++ b/modules/graceful/manager_common.go @@ -10,6 +10,9 @@ import ( "time" ) +// FIXME: it seems that there is a bug when using systemd Type=notify: the "Install Page" (INSTALL_LOCK=false) doesn't notify properly. +// At the moment, no idea whether it also affects Windows Service, or whether it's a regression bug. It needs to be investigated later. + type systemdNotifyMsg string const (