From a4c7ad99e54d0835f759199599a8dcd6f5d7e90e Mon Sep 17 00:00:00 2001 From: Cirno the Strongest <1447794+CirnoT@users.noreply.github.com> Date: Tue, 12 May 2020 05:34:48 +0200 Subject: [PATCH] Fix usage of removed jqXHR.success (#11379) Introduced by b57a735 via removal of jQuery-Migrate. This PR changes usage of .success on jqXHR to .done. Fixes #11228 and few other places, such as removal of code comments. --- web_src/js/index.js | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/web_src/js/index.js b/web_src/js/index.js index 6ac4a1de5d..a74fba34e8 100644 --- a/web_src/js/index.js +++ b/web_src/js/index.js @@ -819,7 +819,7 @@ async function initRepository() { $.post(update_url, { _csrf: csrf, target_branch: targetBranch - }).success((data) => { + }).done((data) => { $branchTarget.text(data.base_branch); }).always(() => { reload(); @@ -1044,7 +1044,7 @@ async function initRepository() { if (window.confirm($this.data('locale'))) { $.post($this.data('url'), { _csrf: csrf - }).success(() => { + }).done(() => { $(`#${$this.data('comment-id')}`).remove(); }); } @@ -2192,7 +2192,7 @@ function initU2FAuth() { } u2fApi.ensureSupport() .then(() => { - $.getJSON(`${AppSubUrl}/user/u2f/challenge`).success((req) => { + $.getJSON(`${AppSubUrl}/user/u2f/challenge`).done((req) => { u2fApi.sign(req.appId, req.challenge, req.registeredKeys, 30) .then(u2fSigned) .catch((err) => { @@ -2288,7 +2288,7 @@ function u2fRegisterRequest() { $.post(`${AppSubUrl}/user/settings/security/u2f/request_register`, { _csrf: csrf, name: $('#nickname').val() - }).success((req) => { + }).done((req) => { $('#nickname').closest('div.field').removeClass('error'); $('#register-device').modal('show'); if (req.registeredKeys === null) {