From a7e98d70b6f20a80e0f98696e9445ff99546676a Mon Sep 17 00:00:00 2001 From: wxiaoguang Date: Wed, 22 Feb 2023 01:09:03 +0800 Subject: [PATCH] Fix the show/hide methods for string selector (#23042) At that moment I made a mistake (failed to detect a JS variable type correctly) Close #23040 --- web_src/js/utils/dom.js | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/web_src/js/utils/dom.js b/web_src/js/utils/dom.js index 8872a9e4ab..d94d4cb092 100644 --- a/web_src/js/utils/dom.js +++ b/web_src/js/utils/dom.js @@ -19,7 +19,7 @@ function assertShown(el, expectShown) { } function elementsCall(el, func, ...args) { - if (el instanceof String) { + if (typeof el === 'string' || el instanceof String) { el = document.querySelectorAll(el); } if (el instanceof Node) { @@ -34,6 +34,10 @@ function elementsCall(el, func, ...args) { } } +/** + * @param el string (selector), Node, NodeList, HTMLCollection, Array or jQuery + * @param force force=true to show or force=false to hide, undefined to toggle + */ function toggleShown(el, force) { if (force === true) { el.classList.remove('gt-hidden');