From ad24a3134d4851aa80e9a385fe97882f6d034020 Mon Sep 17 00:00:00 2001 From: bradder555 Date: Fri, 15 Sep 2017 14:14:06 +0800 Subject: [PATCH] Fixes 500 error on dashboard when using MSSQL (#2504) MSSQL rejects the query: SELECT "repository"."id" FROM "repository" INNER JOIN "team_repo" ON "team_repo".repo_id="repository".id AND "repository".is_mirror=1 WHERE ( ("repository".owner_id=2 AND "repository".is_private=0) OR team_repo.team_id IN (1) ) GROUP BY "repository".id ORDER BY updated_unix DESC when the order by term (updated_unix) is not included in the group by term. --- models/org.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/models/org.go b/models/org.go index fd81753931..31febe2543 100644 --- a/models/org.go +++ b/models/org.go @@ -680,7 +680,7 @@ func (env *accessibleReposEnv) MirrorRepoIDs() ([]int64, error) { Table("repository"). Join("INNER", "team_repo", "`team_repo`.repo_id=`repository`.id AND `repository`.is_mirror=?", true). Where(env.cond()). - GroupBy("`repository`.id"). + GroupBy("`repository`.id, `repository`.updated_unix"). OrderBy("updated_unix DESC"). Cols("`repository`.id"). Find(&repoIDs)