From d1f5584039b46c70e4abfb933a928a28e6065965 Mon Sep 17 00:00:00 2001 From: Gusted Date: Thu, 18 Nov 2021 09:50:22 +0000 Subject: [PATCH] Simplify code for wrting SHA to name-rev (#17696) --- modules/git/pipeline/lfs_nogogit.go | 25 ++++++++----------------- 1 file changed, 8 insertions(+), 17 deletions(-) diff --git a/modules/git/pipeline/lfs_nogogit.go b/modules/git/pipeline/lfs_nogogit.go index a441e37b60..4aa21dd05f 100644 --- a/modules/git/pipeline/lfs_nogogit.go +++ b/modules/git/pipeline/lfs_nogogit.go @@ -217,24 +217,15 @@ func FindLFSFile(repo *git.Repository, hash git.SHA1) ([]*LFSResult, error) { defer wg.Done() defer shasToNameWriter.Close() for _, result := range results { - i := 0 - if i < len(result.SHA) { - n, err := shasToNameWriter.Write([]byte(result.SHA)[i:]) - if err != nil { - errChan <- err - break - } - i += n + _, err := shasToNameWriter.Write([]byte(result.SHA)) + if err != nil { + errChan <- err + break } - var err error - n := 0 - for n < 1 { - n, err = shasToNameWriter.Write([]byte{'\n'}) - if err != nil { - errChan <- err - break - } - + _, err = shasToNameWriter.Write([]byte{'\n'}) + if err != nil { + errChan <- err + break } }