From f9d4bd53e6ace32593f273bb6a57158594f7f3ea Mon Sep 17 00:00:00 2001 From: Lanre Adelowo Date: Fri, 1 Feb 2019 02:37:20 +0100 Subject: [PATCH] support reviewing on a deleted file path (#5880) --- models/issue_comment.go | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/models/issue_comment.go b/models/issue_comment.go index fb379fa941..05756c6cf2 100644 --- a/models/issue_comment.go +++ b/models/issue_comment.go @@ -873,10 +873,11 @@ func CreateCodeComment(doer *User, repo *Repository, issue *Issue, content, tree // No need for get commit for base branch changes if line > 0 { commit, err := gitRepo.LineBlame(pr.GetGitRefName(), gitRepo.Path, treePath, uint(line)) - if err != nil { + if err == nil { + commitID = commit.ID.String() + } else if err != nil && !strings.Contains(err.Error(), "exit status 128 - fatal: no such path") { return nil, fmt.Errorf("LineBlame[%s, %s, %s, %d]: %v", pr.GetGitRefName(), gitRepo.Path, treePath, line, err) } - commitID = commit.ID.String() } // Only fetch diff if comment is review comment