Recalculate repository access only for specific user (#8481)

* Recalculate repository access only for specific user

Signed-off-by: David Svantesson <davidsvantesson@gmail.com>

* Handle user repositories as well, and only add access if minimum mode

* Need to get repo owner to check if organization
This commit is contained in:
David Svantesson 2019-10-15 02:55:21 +02:00 committed by zeripath
parent 733c898a90
commit 8ad2697611
3 changed files with 64 additions and 8 deletions

View File

@ -246,6 +246,55 @@ func (repo *Repository) recalculateTeamAccesses(e Engine, ignTeamID int64) (err
return repo.refreshAccesses(e, accessMap) return repo.refreshAccesses(e, accessMap)
} }
// recalculateUserAccess recalculates new access for a single user
// Usable if we know access only affected one user
func (repo *Repository) recalculateUserAccess(e Engine, uid int64) (err error) {
minMode := AccessModeRead
if !repo.IsPrivate {
minMode = AccessModeWrite
}
accessMode := AccessModeNone
collaborator, err := repo.getCollaboration(e, uid)
if err != nil {
return err
} else if collaborator != nil {
accessMode = collaborator.Mode
}
if err = repo.getOwner(e); err != nil {
return err
} else if repo.Owner.IsOrganization() {
var teams []Team
if err := e.Join("INNER", "team_repo", "team_repo.team_id = team.id").
Join("INNER", "team_user", "team_user.team_id = team.id").
Where("team.org_id = ?", repo.OwnerID).
And("team_repo.repo_id=?", repo.ID).
And("team_user.uid=?", uid).
Find(&teams); err != nil {
return err
}
for _, t := range teams {
if t.IsOwnerTeam() {
t.Authorize = AccessModeOwner
}
accessMode = maxAccessMode(accessMode, t.Authorize)
}
}
// Delete old user accesses and insert new one for repository.
if _, err = e.Delete(&Access{RepoID: repo.ID, UserID: uid}); err != nil {
return fmt.Errorf("delete old user accesses: %v", err)
} else if accessMode >= minMode {
if _, err = e.Insert(&Access{RepoID: repo.ID, UserID: uid, Mode: accessMode}); err != nil {
return fmt.Errorf("insert new user accesses: %v", err)
}
}
return nil
}
func (repo *Repository) recalculateAccesses(e Engine) error { func (repo *Repository) recalculateAccesses(e Engine) error {
if repo.Owner.IsOrganization() { if repo.Owner.IsOrganization() {
return repo.recalculateTeamAccesses(e, 0) return repo.recalculateTeamAccesses(e, 0)

View File

@ -723,7 +723,7 @@ func AddTeamMember(team *Team, userID int64) error {
// Give access to team repositories. // Give access to team repositories.
for _, repo := range team.Repos { for _, repo := range team.Repos {
if err := repo.recalculateTeamAccesses(sess, 0); err != nil { if err := repo.recalculateUserAccess(sess, userID); err != nil {
return err return err
} }
if setting.Service.AutoWatchNewRepos { if setting.Service.AutoWatchNewRepos {
@ -768,7 +768,7 @@ func removeTeamMember(e *xorm.Session, team *Team, userID int64) error {
// Delete access to team repositories. // Delete access to team repositories.
for _, repo := range team.Repos { for _, repo := range team.Repos {
if err := repo.recalculateTeamAccesses(e, 0); err != nil { if err := repo.recalculateUserAccess(e, userID); err != nil {
return err return err
} }

View File

@ -41,12 +41,7 @@ func (repo *Repository) AddCollaborator(u *User) error {
return err return err
} }
if repo.Owner.IsOrganization() { if err = repo.recalculateUserAccess(sess, u.ID); err != nil {
err = repo.recalculateTeamAccesses(sess, 0)
} else {
err = repo.recalculateAccesses(sess)
}
if err != nil {
return fmt.Errorf("recalculateAccesses 'team=%v': %v", repo.Owner.IsOrganization(), err) return fmt.Errorf("recalculateAccesses 'team=%v': %v", repo.Owner.IsOrganization(), err)
} }
@ -89,6 +84,18 @@ func (repo *Repository) GetCollaborators() ([]*Collaborator, error) {
return repo.getCollaborators(x) return repo.getCollaborators(x)
} }
func (repo *Repository) getCollaboration(e Engine, uid int64) (*Collaboration, error) {
collaboration := &Collaboration{
RepoID: repo.ID,
UserID: uid,
}
has, err := e.Get(collaboration)
if !has {
collaboration = nil
}
return collaboration, err
}
func (repo *Repository) isCollaborator(e Engine, userID int64) (bool, error) { func (repo *Repository) isCollaborator(e Engine, userID int64) (bool, error) {
return e.Get(&Collaboration{RepoID: repo.ID, UserID: userID}) return e.Get(&Collaboration{RepoID: repo.ID, UserID: userID})
} }